gh-132775: Unrevert "Add _PyCode_VerifyStateless()" #133528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tateless() (pythongh-133221)" (python#133497)" This reverts commit 3c73cf5.
This reverts commit b943bb0.
|
!buildbot android |
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit bcc081b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133528%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
neonene
reviewed
May 7, 2025
Include/internal/pycore_code.h
Outdated
Comment on lines
637
to
638
| * We consider stateless code to be "portable" if it does not return any | ||
| * any object that holds a reference to any of the code's locals. Thus |
ericsnowcurrently
added a commit
that referenced
this pull request
May 29, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2025
The problem we're fixing here is that we were using PyDict_Size() on "defaults", which it is actually a tuple. We're also adding some explicit type checks. This is a follow-up to pythongh-133221/pythongh-133528. (cherry picked from commit dafd14146f7ca18932894ea445a2f9f98f2a8b01) Co-authored-by: Eric Snow <[email protected]>
ericsnowcurrently
added a commit
that referenced
this pull request
May 29, 2025
gh-132775: Fix _PyFunctIon_VerifyStateless() () The problem we're fixing here is that we were using PyDict_Size() on "defaults", which it is actually a tuple. We're also adding some explicit type checks. This is a follow-up to gh-133221/gh-133528. (cherry picked from commit dafd141, AKA gh-134900) Co-authored-by: Eric Snow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3c73cf5 (gh-133497), which itself reverted the original commit d270bb5 (gh-133221).
We reverted the original change due to failing android tests. The checks in
_PyCode_CheckNoInternalState()were too strict, so we've relaxed them.